Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render command matrix #1658

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Render command matrix #1658

merged 5 commits into from
Jan 26, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Nov 23, 2023 •
edited
Loading

Demo

  1. Run scripts/play.sh
  2. Load http://localhost:5357/command-matrix.html

The rows are sortable by column.

Also

stack build swarm:swarm-docs --fast && stack exec swarm-docs -- cheatsheet --matrix

Screenshot

Screenshot from 2024-01-21 21-32-56

@restyled-io restyled-io bot mentioned this pull request Nov 23, 2023
Closed
@kostmo kostmo force-pushed the feature/command-matrix branch 2 times, most recently from 40af692 to f415529 Compare November 23, 2023 07:48
byorgey
byorgey reviewed Nov 23, 2023
View reviewed changes
src/Swarm/Language/Syntax.hs Outdated Show resolved Hide resolved
src/Swarm/Language/Syntax.hs Outdated Show resolved Hide resolved
src/Swarm/Language/Syntax.hs Outdated Show resolved Hide resolved
src/Swarm/Language/Syntax.hs Outdated Show resolved Hide resolved
src/Swarm/Language/Syntax.hs Outdated Show resolved Hide resolved
@kostmo kostmo force-pushed the feature/command-matrix branch 4 times, most recently from 4bc8f16 to 190df48 Compare January 22, 2024 05:34
@kostmo kostmo marked this pull request as ready for review January 22, 2024 05:36
@kostmo kostmo force-pushed the feature/command-matrix branch 2 times, most recently from de3c88b to f4a77c3 Compare January 22, 2024 05:43
@kostmo kostmo requested a review from byorgey January 24, 2024 21:01
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jan 26, 2024
@mergify mergify bot merged commit 5f53082 into main Jan 26, 2024
9 checks passed
@mergify mergify bot deleted the feature/command-matrix branch January 26, 2024 01:02
@kostmo kostmo added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jul 7, 2024
@kostmo kostmo mentioned this pull request Jul 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jul 30, 2024
@kostmo
remove pandoc dependency from main game (#2084)
f3a15c6 
Closes #2083

Rendering a matrix of command attributes was originally implemented in #1658.  But this generated the data to drive the table at runtime, which pulled in an unfortunate Pandoc dependency.

To work around this, let's just pre-generate the data offline.

# Demo

1. `scripts/play.sh`
2. Visit http://localhost:5357/command-matrix.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey