Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce rectangular map grids #1935

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Enforce rectangular map grids #1935

merged 1 commit into from
Jun 15, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jun 15, 2024 •
edited
Loading

This is a "gotcha" I've run into a few times.

@kostmo kostmo added the Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. label Jun 15, 2024
@kostmo kostmo force-pushed the feature/rectangular-grid-enforcement branch from 0be8637 to ca2bf70 Compare June 15, 2024 19:52
@kostmo kostmo changed the title Enforce rectangular grids Enforce rectangular map grids Jun 15, 2024
@kostmo kostmo force-pushed the feature/rectangular-grid-enforcement branch from ca2bf70 to ef5ec73 Compare June 15, 2024 19:55
@kostmo kostmo requested a review from byorgey June 15, 2024 19:55
@kostmo kostmo marked this pull request as ready for review June 15, 2024 19:55
byorgey
byorgey approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jun 15, 2024
@mergify mergify bot merged commit 85d5d9b into main Jun 15, 2024
13 checks passed
@mergify mergify bot deleted the feature/rectangular-grid-enforcement branch June 15, 2024 20:15
@kostmo kostmo added the CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
CHANGELOG Once merged, this PR should be highlighted in the changelog for the next release. merge me Trigger the merge process of the Pull request. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey