Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify recognizer more #2034

Merged
merged 8 commits into from
Jul 14, 2024
Merged

simplify recognizer more #2034

merged 8 commits into from
Jul 14, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Jul 14, 2024 •
edited
Loading

  • Eliminates redundant EntityName type parameter
  • Removes Ord constraint, uses HashMap/HashSet

@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Jul 14, 2024
@kostmo kostmo force-pushed the refactor/simplify-recognizer-more branch from 59d2e4c to 159ebdb Compare July 14, 2024 06:14
@kostmo kostmo changed the base branch from refactor/extract-more-recognizer-logic to main July 14, 2024 06:15
@kostmo kostmo force-pushed the refactor/simplify-recognizer-more branch from 159ebdb to c73f210 Compare July 14, 2024 06:28
@kostmo kostmo marked this pull request as ready for review July 14, 2024 07:24
@kostmo kostmo requested a review from byorgey July 14, 2024 07:24
byorgey
byorgey approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement/simplification!

src/swarm-topography/Swarm/Game/Scenario/Topography/Structure/Recognition/Prep.hs Show resolved Hide resolved
@xsebek xsebek mentioned this pull request Jul 14, 2024
Closed
@kostmo kostmo force-pushed the refactor/simplify-recognizer-more branch from 544c272 to e4f9d02 Compare July 14, 2024 20:56
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Jul 14, 2024
@mergify mergify bot merged commit 1f1d191 into main Jul 14, 2024
12 checks passed
@mergify mergify bot deleted the refactor/simplify-recognizer-more branch July 14, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xsebek xsebek xsebek left review comments

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostmo @byorgey @xsebek