Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate remaining Cell dependence in structure recognizer #2114

Merged
merged 20 commits into from
Aug 13, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Aug 13, 2024

Builds upon #1836.

Ultimately, this allows us to move the final remaining module, Precompute.hs, into the swarm-topology sublibrary to live alongside the rest of the structure recognizer code.

Also in this PR

  • improve logging details for shape recognition

@kostmo kostmo changed the title [WIP] improve logging details for shape recognition [WIP] eliminate remaining Cell dependence in structure recognizer Aug 13, 2024
@kostmo kostmo force-pushed the feature/improve-recognition-logging branch from e6b6da2 to 4aaed80 Compare August 13, 2024 07:17
@kostmo kostmo changed the title [WIP] eliminate remaining Cell dependence in structure recognizer eliminate remaining Cell dependence in structure recognizer Aug 13, 2024
@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Aug 13, 2024
@kostmo kostmo requested a review from byorgey August 13, 2024 07:21
@kostmo kostmo marked this pull request as ready for review August 13, 2024 07:21
@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Aug 13, 2024
@mergify mergify bot merged commit 1d8f067 into main Aug 13, 2024
12 checks passed
@mergify mergify bot deleted the feature/improve-recognition-logging branch August 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants