Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GHC 9.10 #2131

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow GHC 9.10 #2131

wants to merge 1 commit into from

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Sep 1, 2024

  • add GHC 9.10 to tested
  • regenerate CI
  • allow base 4.20

@xsebek
Allow GHC 9.10
177baad 
* add GHC 9.10 to tested
* regenerate CI
* allow `base` 4.20

---

- blocked by `palette` package - diagrams/palette/pull/9
@xsebek xsebek requested a review from byorgey September 1, 2024 13:54
nitinprakash96
nitinprakash96 reviewed Sep 1, 2024
View reviewed changes
swarm.cabal
@@ -38,7 +38,7 @@ maintainer: byorgey@gmail.com
bug-reports: https://github.com/swarm-game/swarm/issues
copyright: Brent Yorgey 2021
category: Game
tested-with: ghc ==9.2.8 || ==9.4.8 || ==9.6.5 || ==9.8.2
tested-with: ghc ==9.2.8 || ==9.4.8 || ==9.6.5 || ==9.8.2 || ==9.10.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up with #1996
We can probably drop GHC <= 9.4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait with GHC 9.4 since GHCup recommends it. But we could drop 9.2.

@xsebek
Copy link
Member Author

xsebek commented Sep 1, 2024 •
edited
Loading

Note that more dependencies might need their bounds to be relaxed. It all builds and works with --allow-newer, but I would probably have to clean my cache to see if there are more issues.

I am starting to like the relaxed base <5 upper bound that avoids this frequent update. 😄

@byorgey
Copy link
Member

byorgey commented Sep 2, 2024

I am starting to like the relaxed base <5 upper bound that avoids this frequent update.

In general, the problem with base <5 is that if it does break, it does so silently, and anyone trying to build it will spend a half hour building all the dependencies before it finally fails, instead of having it fail immediately. On the other hand, base updates rarely break anything.

I am not sure it matters so much here, since we still have to do the same amount of work updating of other dependencies regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitinprakash96 nitinprakash96 nitinprakash96 left review comments

@byorgey byorgey Awaiting requested review from byorgey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsebek @byorgey @nitinprakash96