Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch for lodestone #2146

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Watch for lodestone #2146

merged 2 commits into from
Sep 15, 2024

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Sep 15, 2024

  • use watch to avoid busy-waiting for the bit seed to grow

Prompted by #2140, which shows hundreds of ishere calls.

Before After
Screenshot 2024-09-15 at 10 02 51 PM Screenshot 2024-09-15 at 10 01 32 PM

This should make the testing scenario take 0.1s from previous 0.5s. You can test it with:

cabal run swarm-integration -O0 -- -p '/Testing\/562-lodestone/

@xsebek xsebek self-assigned this Sep 15, 2024
@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Sep 15, 2024
xsebek added a commit that referenced this pull request Sep 15, 2024
* show time when robot has `time` capability

Prompted by #2146, which used the fancy `rollex` entity for commands but surprisingly did not show time in UI.
@xsebek xsebek mentioned this pull request Sep 15, 2024
@mergify mergify bot merged commit c37334f into main Sep 15, 2024
11 checks passed
@mergify mergify bot deleted the task/xsebek/lodestone-watch branch September 15, 2024 21:07
mergify bot pushed a commit that referenced this pull request Sep 15, 2024
* show time when robot has `time` capability

Prompted by #2146, which used the fancy `rolex` entity for commands but surprisingly did not show time in UI.

You can test it with:
```sh
git cherry-pick ba8dae3  # see before and after adding rolex
cabal run swarm -O0 -- -i data/scenarios/Testing/562-lodestone.yaml --speed 2 --autoplay
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants