Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wall rendering #2153

Merged
merged 1 commit into from
Sep 23, 2024
Merged

use wall rendering #2153

merged 1 commit into from
Sep 23, 2024

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Sep 23, 2024

Makes use of #1285 to simplify wall rendering in several scenarios.

@kostmo kostmo added the Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality. label Sep 23, 2024
@kostmo kostmo requested a review from xsebek September 23, 2024 05:41
@kostmo kostmo marked this pull request as ready for review September 23, 2024 05:42
Copy link
Member

@xsebek xsebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kostmo, maybe this should be part of a tracking issue to get rid of old walls?

@@ -92,7 +92,7 @@ entities:
char: '#'
description:
- Unmovable barrier
properties: [known, unwalkable]
properties: [known, unwalkable, boundary]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one will probably look strange with connected walls, won't it?

Copy link
Member Author

@kostmo kostmo Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the aesthetic, but it does look a bit like random ladders/staircases, which could be misleading.
Maybe at some point I'll consider a more sophisticated renderer that eliminates interior boundaries.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an interesting challenge to specify how such a more sophisticated renderer should work. Like, I think I have an intuitive idea of what I think the result should look like (though it may not be the same as yours), but I think there is some interesting graph theory needed to compute the right drawing. I will see if I can give it some thought.

@byorgey
Copy link
Member

byorgey commented Sep 23, 2024

Thanks @kostmo, maybe this should be part of a tracking issue to get rid of old walls?

We can't quite get rid of all walls, as illustrated by the bucket brigade challenge map.

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Sep 23, 2024
@mergify mergify bot merged commit 5c485ad into main Sep 23, 2024
11 checks passed
@mergify mergify bot deleted the refactor/use-wall-rendering branch September 23, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request. Z-Refactoring This issue is about restructuring the code without changing the behaviour to improve code quality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants