Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new wall in move tutorial #2160

Merged
merged 11 commits into from
Sep 30, 2024
Merged

Use the new wall in move tutorial #2160

merged 11 commits into from
Sep 30, 2024

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Sep 29, 2024

  • add the new boundary wall to entities.yaml
  • use the new boundary wall to simplify the scenario code
    • the door visual is achieved by using an invisible walkable boundary entity called "door"
  • use instant wait
  • directly check the base position in objective conditions
  • use one-line code snippets in the markdown description so that they are rendered on a single line

kostmo
kostmo approved these changes Sep 29, 2024
View reviewed changes
data/entities.yaml Outdated Show resolved Hide resolved
byorgey
byorgey approved these changes Sep 29, 2024
View reviewed changes
data/scenarios/Tutorials/move.yaml Outdated Show resolved Hide resolved
@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Sep 30, 2024
@mergify mergify bot merged commit 0cd9278 into main Sep 30, 2024
14 checks passed
@mergify mergify bot deleted the move_wall branch September 30, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xsebek @kostmo @byorgey