Refactor: move ResourceLoading to swarm-util #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Restyled.io <commits@restyled.io>
xsebek
approved these changes
Sep 30, 2024
kostmo
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
Failureis moved toswarm-util(#2155), that was the last remaining dependency ofSwarm.Game.ResourceLoadingwhich prevented it from moving as well. TheResourceLoadingcode is not specific to Swarm scenarios; this PR moves it toswarm-utilto make it more generally applicable.In fact, the
ResourceLoadingcode is already being used to load.swfiles when executing theRuncommand; in order to implement #495 we will need to do that loading in order to resolveimportexpressions, but that code will live inswarm-lang, which cannot importswarm-scenario.