Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shape recognition with piecewise rows #2201

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Nov 4, 2024

Prerequisites

Overview

Certain hacks (e.g. #2115) were employed to better handle "transparency" when recognizing shapes. However, these approaches are still limited in capability.

The "right" way to use Aho-Corasick with transparency is to break rows up into the contiguous segments separated by transparent cells. The individual segments recognized by the automaton can then be matched against their expected position.

scripts/play.sh --scenario scenarios/Testing/1575-structure-recognizer/2201-piecewise-lines.yaml --autoplay

To view the internal shape recognition logs:

http://localhost:5357/recognize/log

Other notable changes

  • Use Writer monad for logging
  • Remove all "entity masking" logic
  • Update documentation

@kostmo kostmo force-pushed the feature/piecewise-recognition branch 7 times, most recently from 82243b6 to b558b8f Compare November 14, 2024 02:19
@kostmo kostmo force-pushed the feature/piecewise-recognition branch 4 times, most recently from cf4208f to 6bef848 Compare November 14, 2024 16:51
@kostmo kostmo force-pushed the feature/piecewise-recognition branch from 6bef848 to f702056 Compare November 14, 2024 16:59
@kostmo kostmo requested a review from byorgey November 14, 2024 17:01
@kostmo kostmo marked this pull request as ready for review November 14, 2024 17:01
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be honest, I didn't carefully read all the code here, but I appreciate the extensive comments!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Nov 17, 2024
@mergify mergify bot merged commit 27a08ea into main Nov 17, 2024
14 checks passed
@mergify mergify bot deleted the feature/piecewise-recognition branch November 17, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants