Skip to content

Failing test for incomplete inlined function calls #11101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+17 −0
Closed

Failing test for incomplete inlined function calls #11101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions crates/swc_ecma_minifier/tests/fixture/issues/react/hooks/6/input.js
View file
Open in desktop
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It started out hook related but ultimately wasn't. I can't get this test to run locally if I put it in another folder so I left it here.

Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
const decideZoomByAccuracy = (range) => {
const isUnder = (accuracy) => {
return range <= accuracy;
};
if (isUnder(0)) {
return 15;
}
if (isUnder(50)) {
return 15;
}
if (isUnder(100)) {
return 15;
}
return 11;
};
export const zoom = decideZoomByAccuracy(75);
1 change: 1 addition & 0 deletions crates/swc_ecma_minifier/tests/fixture/issues/react/hooks/6/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const zoom = 15;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWC outputs export const zoom = range <= 100 ? 15 : 11; instead which triggers a ReferenceError since range is no longer defined.

Loading