Skip to content

Conversation

quininer
Copy link
Contributor

Description:

This is the split of #11100 . Since we need to add unknown variants to the ast enum, this requires a lot of code changes to handle non-exhaustive match. I'm doing this in a separate PR for review.

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Sep 22, 2025

⚠️ No Changeset found

Latest commit: 58133f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1
Copy link
Member

kdy1 commented Sep 22, 2025

Do you think this should go into the main branch?
Can you change the target to ‘dev/rust’?

@quininer
Copy link
Contributor Author

Sure, I can change it.

@quininer quininer force-pushed the r/ast-non-exhaustive branch from 7e9b1f3 to 5c7ab17 Compare September 24, 2025 12:45
Copy link

socket-security bot commented Sep 24, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​babel/​traverse@​7.22.1100257896100
Added@​ast-grep/​napi-darwin-arm64@​0.3.31001003693100
Added@​ast-grep/​napi-darwin-x64@​0.3.3991003693100
Added@​ast-grep/​napi-linux-x64-gnu@​0.3.31001003693100
Added@​ast-grep/​napi-win32-arm64-msvc@​0.3.3991003693100
Added@​ast-grep/​napi-win32-ia32-msvc@​0.3.3991003693100
Added@​ast-grep/​napi-win32-x64-msvc@​0.3.31001003693100
Added@​types/​terser@​3.12.0661003977100
Added@​swc/​counter@​0.1.31001004277100
Addednode-releases@​2.0.131001004487100
Addedhasown@​2.0.2671007253100
Addedis-core-module@​2.12.1671008253100
Addedfunction-bind@​1.1.2671008353100
Added@​swc/​plugin-jest@​1.5.117801005594100
Added@​babel/​plugin-transform-react-jsx-development@​7.18.61001006191100
Updatedjest-get-type@​25.2.6 ⏵ 29.6.310010063 +184100
Added@​babel/​plugin-syntax-async-generators@​7.8.41001006382100
Added@​babel/​plugin-syntax-import-meta@​7.10.41001006382100
Added@​babel/​plugin-syntax-json-strings@​7.8.31001006382100
Added@​babel/​plugin-syntax-logical-assignment-operators@​7.10.41001006382100
Added@​babel/​plugin-syntax-nullish-coalescing-operator@​7.8.31001006382100
Added@​babel/​plugin-syntax-numeric-separator@​7.10.41001006382100
Added@​babel/​plugin-syntax-object-rest-spread@​7.8.31001006382100
Added@​babel/​plugin-syntax-optional-catch-binding@​7.8.31001006382100
Added@​babel/​plugin-syntax-optional-chaining@​7.8.31001006382100
Added@​babel/​plugin-syntax-dynamic-import@​7.8.31001006382100
Added@​babel/​plugin-syntax-export-namespace-from@​7.8.31001006382100
Added@​babel/​plugin-syntax-private-property-in-object@​7.14.51001006382100
Added@​babel/​plugin-transform-dotall-regex@​7.18.61001006391100
Added@​babel/​plugin-transform-unicode-regex@​7.18.61001006391100
Added@​babel/​plugin-syntax-class-properties@​7.12.131001006382100
Added@​babel/​plugin-syntax-class-static-block@​7.14.51001006382100
Added@​babel/​plugin-syntax-top-level-await@​7.14.51001006382100
See 221 more rows in the dashboard

View full report

Copy link

codspeed-hq bot commented Sep 24, 2025

CodSpeed Performance Report

Merging #11115 will not alter performance

Comparing quininer:r/ast-non-exhaustive (58133f1) with main (8cfd47b)1

Summary

✅ 140 untouched

Footnotes

  1. No successful run was found on main (4c43db2) during the generation of this report, so 8cfd47b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@quininer quininer force-pushed the r/ast-non-exhaustive branch from 5c7ab17 to 58133f1 Compare September 25, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants