fix: Delete project image only if present

swibly · Oct 27, 2024 · 9fab597 · 9fab597
1 parent 0b53830
commit 9fab597
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/internal/service/repository/project.go b/internal/service/repository/project.go
@@ -801,9 +801,11 @@ func (pr *projectRepository) UnsafeDelete(id uint) error {
 		return err
 	}
 
-	if err := aws.DeleteProjectImage(project.BannerURL); err != nil {
-		tx.Rollback()
-		return err
+	if project.BannerURL != "" {
+		if err := aws.DeleteProjectImage(project.BannerURL); err != nil {
+			tx.Rollback()
+			return err
+		}
 	}
 
 	if err := tx.Unscoped().Delete(&project).Error; err != nil {
@@ -899,9 +901,11 @@ func (pr *projectRepository) ClearTrash(userID uint) error {
 	}
 
 	for _, project := range projects {
-		if err := aws.DeleteProjectImage(project.BannerURL); err != nil {
-			tx.Rollback()
-			return err
+		if project.BannerURL != "" {
+			if err := aws.DeleteProjectImage(project.BannerURL); err != nil {
+				tx.Rollback()
+				return err
+			}
 		}
 	}