New model loader for MSFS 2024 #374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltoenning
requested changes
Nov 28, 2025
Member
ltoenning
left a comment
ltoenning
left a comment
There was a problem hiding this comment.
Nice work!
One thing we might need to think about is if at least some common parts can be reused. Otherwise the PR adds quite much duplicate code, possibly making the plugins harder to maintain. Of course this is a tradeoff because of the changes between MSFS2020 and MSFS2024... Maybe we can discuss this soon.
| // clang-format off | ||
| #include <Windows.h> | ||
| //#include <SimConnect.h> | ||
| #include "../third_party/externals/common/include/simconnect/MSFS2024/SimConnect.h" |
Member
There was a problem hiding this comment.
Should be #include <SimConnect.h> with the include paths correctly managed in CMake.
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
Co-authored-by: Lars Toenning <dev@ltoenning.de>
…lotclient into msfs2024_new_ml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version for MSFS2024 modelloader, based on the current main branch. Includes all adjustments for Qt 6.10.1
Please pay particular attention to the sections marked "TODO TZ".