-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Co-authored-by: Honza Dvorsky <honza@apple.com> Co-authored-by: Si Beaumont <beaumont@apple.com> Co-authored-by: David Nadoba <d_nadoba@apple.com>
- Loading branch information
Showing
27 changed files
with
1,424 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
### Motivation | ||
|
||
_[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]_ | ||
|
||
### Modifications | ||
|
||
_[Describe the modifications you've made.]_ | ||
|
||
### Result | ||
|
||
_[After your change, what will change.]_ | ||
|
||
### Test Plan | ||
|
||
_[Describe the steps you took, or will take, to qualify the change - such as adjusting tests and manual testing.]_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
.DS_Store | ||
.build | ||
/Packages | ||
/*.xcodeproj | ||
xcuserdata/ | ||
DerivedData/ | ||
.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata | ||
.vscode | ||
/Package.resolved | ||
.ci/ | ||
.docc-build/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: 1 | ||
builder: | ||
configs: | ||
- documentation_targets: | ||
- OpenAPIAsyncHTTPClient |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
{ | ||
"fileScopedDeclarationPrivacy" : { | ||
"accessLevel" : "private" | ||
}, | ||
"indentation" : { | ||
"spaces" : 4 | ||
}, | ||
"indentConditionalCompilationBlocks" : false, | ||
"indentSwitchCaseLabels" : false, | ||
"lineBreakAroundMultilineExpressionChainComponents" : true, | ||
"lineBreakBeforeControlFlowKeywords" : false, | ||
"lineBreakBeforeEachArgument" : true, | ||
"lineBreakBeforeEachGenericRequirement" : true, | ||
"lineLength" : 120, | ||
"maximumBlankLines" : 1, | ||
"prioritizeKeepingFunctionOutputTogether" : false, | ||
"respectsExistingLineBreaks" : true, | ||
"rules" : { | ||
"AllPublicDeclarationsHaveDocumentation" : false, | ||
"AlwaysUseLowerCamelCase" : false, | ||
"AmbiguousTrailingClosureOverload" : true, | ||
"BeginDocumentationCommentWithOneLineSummary" : false, | ||
"DoNotUseSemicolons" : true, | ||
"DontRepeatTypeInStaticProperties" : false, | ||
"FileScopedDeclarationPrivacy" : true, | ||
"FullyIndirectEnum" : true, | ||
"GroupNumericLiterals" : true, | ||
"IdentifiersMustBeASCII" : true, | ||
"NeverForceUnwrap" : false, | ||
"NeverUseForceTry" : false, | ||
"NeverUseImplicitlyUnwrappedOptionals" : false, | ||
"NoAccessLevelOnExtensionDeclaration" : false, | ||
"NoAssignmentInExpressions" : true, | ||
"NoBlockComments" : true, | ||
"NoCasesWithOnlyFallthrough" : true, | ||
"NoEmptyTrailingClosureParentheses" : true, | ||
"NoLabelsInCasePatterns" : false, | ||
"NoLeadingUnderscores" : false, | ||
"NoParensAroundConditions" : true, | ||
"NoVoidReturnOnFunctionSignature" : true, | ||
"OneCasePerLine" : true, | ||
"OneVariableDeclarationPerLine" : true, | ||
"OnlyOneTrailingClosureArgument" : true, | ||
"OrderedImports" : false, | ||
"ReturnVoidInsteadOfEmptyTuple" : true, | ||
"UseEarlyExits" : true, | ||
"UseLetInEveryBoundCaseVariable" : false, | ||
"UseShorthandTypeNames" : true, | ||
"UseSingleLinePropertyGetter" : false, | ||
"UseSynthesizedInitializer" : true, | ||
"UseTripleSlashForDocumentationComments" : true, | ||
"UseWhereClausesInForLoops" : false, | ||
"ValidateDocumentationComments" : false | ||
}, | ||
"spacesAroundRangeFormationOperators" : false, | ||
"tabWidth" : 8, | ||
"version" : 1 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Code of Conduct | ||
|
||
The code of conduct for this project can be found at https://swift.org/code-of-conduct. | ||
|
||
<!-- Copyright (c) 2023 Apple Inc and the Swift Project authors. All Rights Reserved. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
## Legal | ||
|
||
By submitting a pull request, you represent that you have the right to license | ||
your contribution to Apple and the community, and agree by submitting the patch | ||
that your contributions are licensed under the Apache 2.0 license (see | ||
`LICENSE.txt`). | ||
|
||
## How to submit a bug report | ||
|
||
Please report any issues related to this library in the [swift-openapi-generator](https://github.com/apple/swift-openapi-generator/issues) repository. | ||
|
||
Specify the following: | ||
|
||
* Commit hash | ||
* Contextual information (e.g. what you were trying to achieve with swift-openapi-async-http-client) | ||
* Simplest possible steps to reproduce | ||
* More complex the steps are, lower the priority will be. | ||
* A pull request with failing test case is preferred, but it's just fine to paste the test case into the issue description. | ||
* Anything that might be relevant in your opinion, such as: | ||
* Swift version or the output of `swift --version` | ||
* OS version and the output of `uname -a` | ||
* Network configuration | ||
|
||
### Example | ||
|
||
``` | ||
Commit hash: b17a8a9f0f814c01a56977680cb68d8a779c951f | ||
Context: | ||
While testing my application that uses with swift-openapi-async-http-client, I noticed that ... | ||
Steps to reproduce: | ||
1. ... | ||
2. ... | ||
3. ... | ||
4. ... | ||
$ swift --version | ||
Swift version 4.0.2 (swift-4.0.2-RELEASE) | ||
Target: x86_64-unknown-linux-gnu | ||
Operating system: Ubuntu Linux 16.04 64-bit | ||
$ uname -a | ||
Linux beefy.machine 4.4.0-101-generic #124-Ubuntu SMP Fri Nov 10 18:29:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux | ||
My system has IPv6 disabled. | ||
``` | ||
|
||
## Writing a Patch | ||
|
||
A good patch is: | ||
|
||
1. Concise, and contains as few changes as needed to achieve the end result. | ||
2. Tested, ensuring that any tests provided failed before the patch and pass after it. | ||
3. Documented, adding API documentation as needed to cover new functions and properties. | ||
4. Accompanied by a great commit message, using our commit message template. | ||
|
||
### Run `./scripts/soundness.sh` | ||
|
||
The scripts directory contains a [soundness.sh script](https://github.com/swift-server/swift-openapi-async-http-client/blob/main/scripts/soundness.sh) | ||
that enforces additional checks, like license headers and formatting style. | ||
|
||
Please make sure to `./scripts/soundness.sh` before pushing a change upstream, otherwise it is likely the PR validation will fail | ||
on minor changes such as a missing `self.` or similar formatting issues. | ||
|
||
For frequent contributors, we recommend adding the script as a [git pre-push hook](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks), which you can do via executing the following command in the project root directory: | ||
|
||
```bash | ||
cat << EOF > .git/hooks/pre-push | ||
if [[ -f "scripts/soundness.sh" ]]; then | ||
scripts/soundness.sh | ||
fi | ||
EOF | ||
``` | ||
|
||
Which makes the script execute, and only allow the `git push` to complete if the check has passed. | ||
|
||
In the case of formatting issues, you can then `git add` the formatting changes, and attempt the push again. | ||
|
||
## How to contribute your work | ||
|
||
Please open a pull request at https://github.com/swift-server/swift-openapi-async-http-client. Make sure the CI passes, and then wait for code review. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
For the purpose of tracking copyright, this is the list of individuals and | ||
organizations who have contributed source code to SwiftOpenAPIGenerator. | ||
|
||
For employees of an organization/company where the copyright of work done | ||
by employees of that company is held by the company itself, only the company | ||
needs to be listed here. | ||
|
||
## COPYRIGHT HOLDERS | ||
|
||
- Apple Inc. (all contributors with '@apple.com') | ||
|
||
### Contributors | ||
|
||
- David Nadoba <d_nadoba@apple.com> | ||
- Honza Dvorsky <honza@apple.com> | ||
- Si Beaumont <beaumont@apple.com> | ||
|
||
**Updating this list** | ||
|
||
Please do not edit this file manually. It is generated using `./scripts/generate-contributors-list.sh`. If a name is misspelled or appearing multiple times: add an entry in `./.mailmap` |
Oops, something went wrong.