Ensure the macOS SDK exists at install time #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justice-adams-apple
requested review from
cmcgee1024,
etcwilde and
shahmishal
as code owners
justice-adams-apple
changed the title
justice-adams-apple
force-pushed
the
jadams/macos-sdk-detection
branch
from
49221af to
cff35d2
Compare
justice-adams-apple
force-pushed
the
jadams/macos-sdk-detection
branch
from
cff35d2 to
66c91cb
Compare
shahmishal
reviewed
Dec 12, 2025
Sources/MacOSPlatform/MacOS.swift
Outdated
| // shell script for installing developer tools on macOS. | ||
| if !result.terminationStatus.isSuccess { | ||
| await ctx.print(""" | ||
| \nWARNING: Could not find a macOS SDK on the system. A macOS SDK is required for the toolchain to work correctly. Please install one via Xcode (https://developer.apple.com/xcode) or run the following command on your machine to install the command line developer tools: `xcode-select --install`. |
Member
There was a problem hiding this comment.
Suggested change
| \nWARNING: Could not find a macOS SDK on the system. A macOS SDK is required for the toolchain to work correctly. Please install one via Xcode (https://developer.apple.com/xcode) or run the following command on your machine to install the command line developer tools: `xcode-select --install`. | |
| \nWARNING: Could not find a macOS SDK on the system. A macOS SDK is required for the toolchain to work correctly. Please install one via Xcode (https://developer.apple.com/xcode) or run the following command on your machine to install the Command Line Tools for Xcode `xcode-select --install`. |
cmcgee1024
reviewed
Dec 12, 2025
Sources/MacOSPlatform/MacOS.swift
Outdated
| // shell script for installing developer tools on macOS. | ||
| if !result.terminationStatus.isSuccess { | ||
| await ctx.print(""" | ||
| \nWARNING: Could not find a macOS SDK on the system. A macOS SDK is required for the toolchain to work correctly. Please install one via Xcode (https://developer.apple.com/xcode) or run the following command on your machine to install the command line developer tools: `xcode-select --install`. |
Member
There was a problem hiding this comment.
suggestion: To make it easier for users to copy/paste the command it should go an a separate line here.
Member
|
Are you sure the command-line tools install includes Foundation and XCTest? I installed those CLI tools alone and I was able to build against |
Member
|
Foundation is there in the CLT's version of the macOS SDK, but not XCTest. |
Member
|
@justice-adams-apple can you cherry-pick this on release/1.1? |
Member
|
I think the core libraries that require Xcode should be listed out too, as many Swift packages won't compile or test for macOS without XCTest. |
justice-adams-apple
added a commit
that referenced
this pull request
Dec 13, 2025
* Ensure the macOS SDK exists at install time * update warning messaging * remove backticks (cherry picked from commit 20ceb47)
shahmishal
pushed a commit
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning that the end-user will receive is the following (currently):