Make project localizable #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @d0ul Thanks for opening this PR, it means a lot to us. What's the progress on localization? I see there are two unchecked TODOs. |
Author
I actually forgot this PR for like months ago. It'll be done as soon as I have enough time to complete one. |
|
Taking a swing to integrate the missing strings, it might take a bit tho (fighting with tooling mainly). |
|
Components has been fully translated (minus a few since the name is used in the code as switching statements). I've started the context menus now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
I am currently using Swing Music flawlessly, but I wanted to make some translations to this project.
As English values are hard coded, it was impossible to translate this project into multiple languages.
So I have added Vue-i18n plugin so it makes translation much easier.
Progress