Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt iso20022ReportReference #72

Merged
merged 20 commits into from
Jan 22, 2024

Conversation

svenbiellmann
Copy link
Contributor

New iso20022ReportReference properties (schemaVersion, dateFrom, dateTo) are added. The added properties are optional.

@svenbiellmann svenbiellmann requested a review from a team as a code owner December 27, 2023 15:40
@svenbiellmann svenbiellmann linked an issue Dec 27, 2023 that may be closed by this pull request
@svenbiellmann svenbiellmann added this to the v4.0 milestone Dec 27, 2023
Copy link
Collaborator

@simonmeyerm simonmeyerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove element "conditionList" from properties in endpoint response.
This element does not exist in bLink specification and has no additional value from my perspective.
The element was added with the initial merge with the ISO20022 endpoints.

@svenbiellmann
Copy link
Contributor Author

Please remove element "conditionList" from properties in endpoint response. This element does not exist in bLink specification and has no additional value from my perspective. The element was added with the initial merge with the ISO20022 endpoints.

Element "conditonList" removed from properties in endpoint response and pull request updated.

Copy link
Contributor

@dkoeni dkoeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved.

@svenbiellmann svenbiellmann merged commit a79a79e into main Jan 22, 2024
1 check passed
@svenbiellmann svenbiellmann deleted the ais-adapt-get-iso20022statements-response branch January 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET /iso20022/statements - Add date and IBAN to list
3 participants