Conversation
Tekton template engine uses missingkey=error mode, which throws error when accessing map keys that don't exist. Frontend was not initializing optional fields with empty default values, causing build failures. Changes: - Add "default": "" to app_username in MySQL config - Add "default": "" to app_username in MongoDB config - Ensures consistent JSON structure for all optional fields This prevents "map has no entry for key" errors during Dockerfile template rendering in Tekton build pipeline. LP-487
Removes "(선택사항)" text from labels where category is already "optional" to avoid redundancy in UI. Also ensures consistent JSON structure by adding missing "default": "" keys. Changes: - MySQL: Remove "(선택사항)" from app_username and app_password labels - MongoDB: Remove "(선택사항)" from app_username and app_password labels - All templates audited: 13 other templates already correct This improves UI clarity and maintains consistent JSON structure across all 15 templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix redundant optional label text in MySQL/MongoDB templates
Summary
Changes
MySQL Template (templates/mysql/config.json)
app_usernamelabel:"애플리케이션 사용자명 (선택사항)"→"애플리케이션 사용자명"app_passwordlabel:"애플리케이션 비밀번호 (선택사항)"→"애플리케이션 비밀번호"MongoDB Template (templates/mongodb/config.json)
app_usernamelabel:"애플리케이션 사용자명 (선택사항)"→"애플리케이션 사용자명"app_passwordlabel:"애플리케이션 비밀번호 (선택사항)"→"애플리케이션 비밀번호"