Replace StatusItems with a Process Tree #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the language server (and the extension by proxy) is managing mutliple sphinx processes, there is too much information to try and cram into a set of language status items. Instead the extension now contributes a "Sphinx Processes" tree view which can visualise each process currently managed by the server. Not only should this be more discoverable, but offers a space to expose additonal management commands - such as restarting processes or triggering builds.
This section will contain all the information on how to integrate Esbonio into your favourite editor, including documentation on any custom notifications/commands used by the server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, there's too much information for the extension to try and cram into a few Language status items, especially now that there can be more than one underlying Sphinx process.
So this PR removes them and introduces a custom tree view contributed to the Explorer pane. The tree view is able to display the state of each process at a glance.
The tree view also provides a convenient place to expose some additional management commands.
Included in this PR is a
esbonio.sphinx.restartcommand which can be used to restart an individual Sphinx process - without restarting the entire server.