Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for :external: role completions #856

Merged
merged 4 commits into from
Jul 19, 2024

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    e8da3ee View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. sphinx-agent: Dump intersphinx inventories in the DB

    This adds code to dump all objects defined in intersphinx inventories
    into the `objects` table in the SQLite DB.
    
    So that the language server can distinguish between local objects and
    objects defined in another project, the `objects` table has been
    extended to include a `project` column. It will be `NULL` for objects
    in the local project or be set to the intersphinx inventory name
    otherwise.
    
    To ensure that the language server is able to surface these items in
    completions this commit updates the domain role indexing code to
    also store `external:domain:role` and `external+invname:domain:role`
    variants of the role in the DB.
    
    This feels... hacky but seems to work well. Maybe this can be
    revisited in the future and improved with a more dynamic role
    completion system...
    alcarney committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c359cda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    97ed269 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    527c9d6 View commit details
    Browse the repository at this point in the history