-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce StaticCache compile time #6426
Reduce StaticCache compile time #6426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement. Looks good except for some commented development code. All the clang-tidy output is just it being confused, so that CI job can be ignored.
src/Utilities/StaticCache.hpp
Outdated
// IntegralConstantValues..., IntegralConstants0, | ||
// IntegralConstant1>; | ||
// ++counter0; | ||
// }()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove commented code.
Use if-constexpr to make it easire to read.
This change reduces compile time by ~25% for DgSubcell/Matrices.cpp
Reduces compile time by a few percent in DgSubcell/Matrices.cpp
2248180
to
506859a
Compare
Done and rebased. Thanks for the review!! |
Proposed changes
Some timings on mbot:
The last commit simplifies the code quite a bit, IMO, which is why I did it.
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments