Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce StaticCache compile time #6426

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Some timings on mbot:

Timings for DgSubcell/Matrices.cpp
 Original: 46
 Combine static cache generate_tuple functions: 46
 Move integral static cache range check: 40
 Change StaticCache enum indexing and bounds check:  22
 Combine enum and integer caching logic in StaticCache: 20
Improve StaticCache compilation time using multiple peelings: 10
Simplifying DgSubcell matrix caching code: 12

The last commit simplifies the code quite a bit, IMO, which is why I did it.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Looks good except for some commented development code. All the clang-tidy output is just it being confused, so that CI job can be ignored.

// IntegralConstantValues..., IntegralConstants0,
// IntegralConstant1>;
// ++counter0;
// }());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented code.

@nilsdeppe nilsdeppe force-pushed the speedup_static_cache branch from 2248180 to 506859a Compare January 14, 2025 00:44
@nilsdeppe
Copy link
Member Author

Done and rebased. Thanks for the review!!

@nilsdeppe nilsdeppe merged commit 889d03e into sxs-collaboration:develop Jan 14, 2025
21 of 23 checks passed
@nilsdeppe nilsdeppe deleted the speedup_static_cache branch January 14, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants