Start of BinaryWithGravitationalWaves class for XCTS #6428

joaorebelo-megum · 2025-01-04T20:09:16Z

Proposed changes

Creation of the class BinaryWithGravitationalWaves for XCTS solver, that computes initial data for binary black hole with realistic wave content.
The conformal data is obtained from a superposition of two boosted objects plus radiative content computed from Post-Newtonian Theory.

Code review checklist

The code is documented and the documentation renders correctly. Run
make doc to generate the documentation locally into BUILD_DIR/docs/html.
Then open index.html.
The code follows the stylistic and code quality guidelines listed in the
code review guide.
The PR lists upgrade instructions and is labeled bugfix or
new feature if appropriate.

Further comments

The radiative terms are still not computed (set to zero), they will be added in a later PR.
Supersedes past PR #5799.

- class to implement background data - superposition of two boosted black holes - no radiative content is added for now Additional BoundaryCondition class (Dirichlet): SuperposedBoostedBinary

hrueter

Can you add an example options input file for this?

hrueter · 2025-01-06T14:20:14Z

docs/References.bib

+@article{Baumgarte2007ht,
+    author = "Baumgarte, Thomas W. and Naculich, Stephen G.",
+    title = "{Analytical representation of a black hole puncture solution}",
+    eprint = "gr-qc/0701037",
+    archivePrefix = "arXiv",
+    reportNumber = "BOW-PH-138",
+    doi = "10.1103/PhysRevD.75.067502",
+    url = {https://doi.org/10.1103/PhysRevD.75.067502},
+    journal = "Phys. Rev. D",
+    volume = "75",
+    pages = "067502",
+    year = "2007"
+}
+


This article is not referenced in this PR and probably a leftover from PR #6427

hrueter · 2025-01-06T14:44:57Z

src/Elliptic/Systems/Xcts/BoundaryConditions/SuperposedBoostedBinary.hpp

+/*!
+ * \brief Impose supperposed boosted binary system on the boundary.
+ *
+ * This takes two isolated objects and after applying a boost to each of them,
+ * superposes them. The superposed system is then imposed on the boundary, with
+ * Dirichlet or Neumann boundary conditions.
+ *
+ * \warning The Neumann boundary conditions is not yet implemented.
+ *
+ */


Add some formulas how the superposition is carried out in practice or reference the functions that are used.

hrueter · 2025-01-06T19:37:25Z

docs/References.bib

+    title = "{Binary black hole initial data for numerical general relativity
+             based on postNewtonian data}",


Please correct the title: "post-Newtonian"

hrueter · 2025-01-06T19:38:13Z

docs/References.bib

@@ -2593,6 +2668,21 @@ @book{ThorneBlandford2017
  publisher  = "Princeton University Press",
 }

+@article{Tichy2002ec,
+    author = "Tichy, Wolfgang and Bruegmann, Bernd and Campanelli, Manuela


Bruegmann -> Br\"ugmann

hrueter · 2025-01-06T19:39:33Z

docs/References.bib

@@ -1318,6 +1346,21 @@ @Article{Hou2007
  url     = "https://doi.org/10.1007/s10915-006-9105-9"
 }

+@article{Jaranowski1997ky,
+    author = "Jaranowski, Piotr and Schaefer, Gerhard",


Schaefer -> Sch\"afer

hrueter · 2025-02-03T18:51:09Z

src/PointwiseFunctions/AnalyticData/Xcts/BinaryWithGravitationalWaves.cpp

+
+  for (size_t i = 0; i < 3; ++i) {
+    for (size_t j = 0; j <= i; ++j) {
+      // Third order


comment: "Third order backwards finite difference" (over -2 alpha)

hrueter · 2025-02-03T18:59:07Z

src/PointwiseFunctions/AnalyticData/Xcts/BinaryWithGravitationalWaves.cpp

+      (turn_off + .5 * tanh(attenuation_parameter *
+                            (get(distance_left_t) - attenuation_radius))) *
+      (turn_off + .5 * tanh(attenuation_parameter *
+                            (get(distance_right_t) - attenuation_radius)));


store the attenuation function so that you don't have to recompute it 20 lines below.

hrueter · 2025-02-03T18:59:41Z

src/PointwiseFunctions/AnalyticData/Xcts/BinaryWithGravitationalWaves.cpp

+        (turn_off + .5 * tanh(attenuation_parameter *
+                              (get(distance_left_t) - attenuation_radius))) *
+        (turn_off + .5 * tanh(attenuation_parameter *
+                              (get(distance_right_t) - attenuation_radius)));


store the attenuation function

hrueter · 2025-02-03T19:11:49Z

src/PointwiseFunctions/AnalyticData/Xcts/BinaryWithGravitationalWaves.hpp

+ * The main goal of this implementation is to improve the extracted
+ * wave forms, for example, by minimizing junk radiation.
+ * The data is only valid for black holes without spin. Even so, there is some
+ * work done to describe such systems that could later be implemented.


Can you cite this work?

hrueter · 2025-02-03T19:30:04Z

tests/Unit/PointwiseFunctions/AnalyticData/Xcts/Test_BinaryWithGravitationalWaves.cpp

+  }
+
+  BinaryWithGravitationalWaves<IsolatedObjectBase, IsolatedObjectClasses>*
+      BinaryWithGravitationalWaves_ptr;


Here you are using Hungarian notation.
Instead
BinaryWithGravitationalWaves_ptr -> binary_with_gravitational_waves

hrueter · 2025-02-07T12:41:45Z

docs/References.bib

@@ -2554,6 +2554,20 @@ @article{Stamm2010
  volume   = "79",
 }

+@article{Steinhoff2008zr,
+    author = "Steinhoff, Jan and Schaefer, Gerhard and Hergt, Steven",


Sch\"afer

hrueter · 2025-02-07T12:48:27Z

src/PointwiseFunctions/AnalyticData/Xcts/BinaryWithGravitationalWaves.cpp

+  const auto auxiliar_two = tenex::evaluate<ti::I, ti::J>(
+      inv_conformal_metric(ti::I, ti::K) * inv_conformal_metric(ti::J, ti::L) *
+      conformal_metric(ti::k, ti::l));


This is unnecessary. The result is the inverse conformal metric, which you already have!

joaorebelo-megum force-pushed the BinaryWithGravitationalWaves_first branch 3 times, most recently from 1ca11ea to 01eac03 Compare January 24, 2025 15:43

Start of BinaryWithGravitationalWaves class for XCTS

5f85c71

- class to implement background data - superposition of two boosted black holes - no radiative content is added for now Additional BoundaryCondition class (Dirichlet): SuperposedBoostedBinary

joaorebelo-megum force-pushed the BinaryWithGravitationalWaves_first branch from e64e1e9 to 5f85c71 Compare January 26, 2025 18:17

hrueter suggested changes Feb 3, 2025

View reviewed changes

hrueter requested a review from nilsvu February 3, 2025 19:41

Fixup: comments from PR by Hannes

1b1e6eb

hrueter suggested changes Feb 7, 2025

View reviewed changes

Fixup: last two comments in PR

0b2ba94

hrueter approved these changes Feb 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start of BinaryWithGravitationalWaves class for XCTS #6428

Start of BinaryWithGravitationalWaves class for XCTS #6428

joaorebelo-megum commented Jan 4, 2025

hrueter left a comment

hrueter Jan 6, 2025

hrueter Jan 6, 2025

hrueter Jan 6, 2025

hrueter Jan 6, 2025

hrueter Jan 6, 2025

hrueter Feb 3, 2025

hrueter Feb 3, 2025

hrueter Feb 3, 2025

hrueter Feb 3, 2025

hrueter Feb 3, 2025

hrueter Feb 7, 2025

hrueter Feb 7, 2025

		title = "{Binary black hole initial data for numerical general relativity
		based on postNewtonian data}",

Start of BinaryWithGravitationalWaves class for XCTS #6428

Are you sure you want to change the base?

Start of BinaryWithGravitationalWaves class for XCTS #6428

Conversation

joaorebelo-megum commented Jan 4, 2025

Proposed changes

Code review checklist

Further comments

hrueter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment