Fix clang-tidy on things including libsharp #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempted IWYU replacement. I think it shows promise, but it's not ready. In particular, there's no way to get it to not try to include private headers of system libraries.
Needs the installed headers.
kidder
reviewed
Jan 28, 2025
| @@ -59,6 +59,8 @@ Checks: '*, | |||
| -misc-confusable-identifiers, | |||
| # thinks constexpr variables in header files cause ODR violations, | |||
| -misc-definitions-in-headers, | |||
| # Insufficiently configurable, does not handle system headers well, | |||
| -misc-include-cleaner, | |||
There was a problem hiding this comment.
- I've been using it some to check for missing/extra includes and agree it has some promise, but also agree it definitely needs some control over its behavior before enabling it on CI.
- in addition to the private system includes, I also got errors I'd like to ignore when including macros from other files
nilsdeppe
approved these changes
Jan 28, 2025
knelli2
added
build system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disable a new check with a lot of false positives.
Proposed changes
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments