Skip to content

Avoid assumptions about history in dense output #6466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Jan 31, 2025

The generic dense output code previously made assumptions about how the time stepper used substeps when initializing the variables for dense output. I have accidentally broken this multiple times while experimenting with various things, and the problems are sometimes subtle.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The generic dense output code previously made assumptions about how
the time stepper used substeps when initializing the variables for
dense output.  I have accidentally broken this multiple times while
experimenting with various things, and the problems are sometimes
subtle.
@nilsdeppe nilsdeppe merged commit a7f21ab into sxs-collaboration:develop Feb 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants