fix: remove peer as well as addresses from peerstore (#359)

sygmaprotocol · Sep 16, 2024 · fca7423 · fca7423
1 parent d292ca0
commit fca7423
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/comm/p2p/host.go b/comm/p2p/host.go
@@ -48,6 +48,7 @@ func NewHost(privKey crypto.PrivKey, networkTopology *topology.NetworkTopology,
 // LoadPeers clears out peerstore and loads new peers into it
 func LoadPeers(h host.Host, peers []*peer.AddrInfo) {
 	for _, p := range h.Peerstore().Peers() {
+		h.Peerstore().RemovePeer(p)
 		h.Peerstore().ClearAddrs(p)
 	}
 

diff --git a/comm/p2p/host_test.go b/comm/p2p/host_test.go
@@ -54,8 +54,7 @@ func (s *HostTestSuite) TestHost_NewHost_Success() {
 	)
 	s.Nil(err)
 	s.NotNil(host)
-	// 2 peers + host
-	s.Len(host.Peerstore().Peers(), 3)
+	s.Len(host.Peerstore().Peers(), 2)
 }
 
 func (s *HostTestSuite) TestHost_NewHost_InvalidPrivKey() {
@@ -117,5 +116,5 @@ func (s *LoadPeersTestSuite) Test_LoadPeers_RemovesOldAndSetsNewPeers() {
 
 	s.Equal(peerInSlice(newP1.ID, s.host.Peerstore().Peers()), true)
 	s.Equal(peerInSlice(newP2.ID, s.host.Peerstore().Peers()), true)
-	s.Equal(len(s.host.Peerstore().Peers()), 3)
+	s.Equal(len(s.host.Peerstore().Peers()), 2)
 }