Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listeners not retrying failed event handlers #229

Merged
merged 4 commits into from
Oct 19, 2023
Merged

fix: listeners not retrying failed event handlers #229

merged 4 commits into from
Oct 19, 2023

Conversation

mpetrun5
Copy link
Collaborator

Integrate changes from core and add the changes to the substrate listener.
Make the retryable calls errors log warn level.

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@mpetrun5
Copy link
Collaborator Author

@P1sar Can we send a notification from Datadog if we have many warn messages inside a period of time?

Before everything was error which kinda made us ignore it.
After this PR those logs will be warn, but we still want an error message if there is many of them in a span of time (let's say 15/30 min).

@github-actions
Copy link
Contributor

Go Test coverage is 64.5 %\ ✨ ✨ ✨

@P1sar
Copy link
Contributor

P1sar commented Oct 17, 2023

@P1sar Can we send a notification from Datadog if we have many warn messages within a period of time?

Before everything was an error which kinda made us ignore it. After this PR those logs will be warned, but we still want an error message if there are many of them in a span of time (let's say 15/30 min).

Yeah, that makes sense, I was already trying to do this and will try one more time. Going to create a task for this.

@mpetrun5 mpetrun5 merged commit 37567c9 into main Oct 19, 2023
8 checks passed
@mpetrun5 mpetrun5 deleted the bump-core branch October 19, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants