-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Config files and other minor refactors #252
Merged
mj52951
merged 23 commits into
sygma-core-refactor
from
mj52951/config-and-other-refactor
Mar 18, 2024
Merged
chore: Config files and other minor refactors #252
mj52951
merged 23 commits into
sygma-core-refactor
from
mj52951/config-and-other-refactor
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj52951
requested review from
mpetrun5,
tcar121293,
MakMuftic,
nmlinaric and
freddyli7
as code owners
February 14, 2024 08:00
mpetrun5
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just check the comment please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config files are now refactored so they now use
sygma-core
instead of deprecatedchainbridge-core
. Also, other files have been refactored so that they import onlysygma-core
.Note: e2e, unit and lint tests should fail as this is a step-by-step refactor focusing on smaller parts that should work