Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add btc deposit format explanation #318

Merged
merged 2 commits into from
Jul 10, 2024
Merged

chore: add btc deposit format explanation #318

merged 2 commits into from
Jul 10, 2024

Conversation

tcar121293
Copy link
Contributor

add btc deposit format explanation

Description

Related Issue Or Context

Closes: https://veridise.notion.site/Unclear-BTC-transaction-assumptions-6b182f76f4c14f9ea967a83e97e532df

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293
add btc deposit format explanation;
1f79355 
Signed-off-by: tcar <tcar121293@gmail.com>
mpetrun5
mpetrun5 requested changes Jun 25, 2024
View reviewed changes
docs/general/BTC-Deposit-Format.md Outdated Show resolved Hide resolved
docs/general/Arhitecture.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.0 %\ ✨ ✨ ✨

@tcar121293
rename the deposit docs file;
748868f 
Signed-off-by: tcar <tcar121293@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.1 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 080554c into main Jul 10, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the tcar/update-docs branch July 10, 2024 12:08
@MakMuftic MakMuftic mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@nmlinaric nmlinaric nmlinaric approved these changes

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcar121293 @mpetrun5 @nmlinaric