Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schnorr signature hash missing leading zeroes #341

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mpetrun5
Copy link
Collaborator

*big.Int that ECDSA uses to pass messages removes leading zeroes which then construes a different hash than the Bitcoin node expects.
This changes everything to use []byte directly.

Description

Related Issue Or Context

Closes: #340

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

Go Test coverage is 66.9 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 34f52b1 into main Jul 24, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the fix/schnorr-signature-inconsistency branch July 24, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid schnorr signature when sending transaction
3 participants