Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: frost key resharing #346

Merged
merged 4 commits into from
Aug 13, 2024
Merged

fix: frost key resharing #346

merged 4 commits into from
Aug 13, 2024

Conversation

tcar121293
Copy link
Contributor

Store verificationShares on the new relayer

Description

Related Issue Or Context

Closes: #345

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293
fix frost key resharing;
f03ec42 
Signed-off-by: tcar <tcar121293@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.0 %\ ✨ ✨ ✨

mpetrun5
mpetrun5 requested changes Aug 13, 2024
View reviewed changes
tss/frost/resharing/resharing.go Outdated Show resolved Hide resolved
@mpetrun5 mpetrun5 changed the title fix: fix frost key resharing fix: frost key resharing Aug 13, 2024
@tcar121293
set publicKey only if missing;
956aaef 
Signed-off-by: tcar <tcar121293@gmail.com>
@tcar121293
update docker compose command;
9843088 
Signed-off-by: tcar <tcar121293@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.0 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.0 %\ ✨ ✨ ✨

@tcar121293 tcar121293 merged commit 7b35e11 into main Aug 13, 2024
8 checks passed
@tcar121293 tcar121293 deleted the tcar/fix-frost-resharing branch August 13, 2024 12:12
@MakMuftic MakMuftic mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsuccessful frost key reshare
3 participants
@tcar121293 @mpetrun5 @MakMuftic