Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Multiple GSRPC version support #347

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat: Multiple GSRPC version support #347

merged 2 commits into from
Aug 19, 2024

Conversation

freddyli7
Copy link
Contributor

@freddyli7 freddyli7 commented Aug 14, 2024 •
edited
Loading

Description

This PR is adding multiple GSRPC lib version support

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 66.7 %\ ✨ ✨ ✨

@freddyli7 freddyli7 changed the title feat: Multiple GSRPC version support feat: Multiple GSRPC version support DO NOT MERGE Aug 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 66.7 %\ ✨ ✨ ✨

@freddyli7 freddyli7 changed the title feat: Multiple GSRPC version support DO NOT MERGE feat: Multiple GSRPC version support Aug 19, 2024
@freddyli7 freddyli7 changed the base branch from main to relase/v2.2.1-rc August 19, 2024 14:01
@freddyli7 freddyli7 marked this pull request as ready for review August 19, 2024 14:02
@mpetrun5 mpetrun5 merged commit 661cd42 into relase/v2.2.1-rc Aug 19, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the freddy/multiple-go-substrate-version-support branch August 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@MakMuftic MakMuftic Awaiting requested review from MakMuftic MakMuftic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freddyli7 @mpetrun5 @MakMuftic