Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return error when upload to ipfs fails #350

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

tcar121293
Copy link
Contributor

Return error when upload to ipfs fails

Description

return error when upload to ipfs fails

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Signed-off-by: tcar <tcar121293@gmail.com>
Copy link
Contributor

Go Test coverage is 66.7 %\ ✨ ✨ ✨

Signed-off-by: tcar <tcar121293@gmail.com>
Signed-off-by: tcar <tcar121293@gmail.com>
@mpetrun5 mpetrun5 changed the title chore: return error when upload to ipfs fails fix: return error when upload to ipfs fails Aug 21, 2024
Copy link
Contributor

Go Test coverage is 66.7 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit 8aff649 into main Aug 21, 2024
7 of 8 checks passed
@mpetrun5 mpetrun5 deleted the tcar/return-error-when-uploading branch August 21, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants