Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shared configuration upgrades #111

Merged
merged 7 commits into from
May 24, 2024
Merged

feat: shared configuration upgrades #111

merged 7 commits into from
May 24, 2024

Conversation

MakMuftic
Copy link
Contributor

@MakMuftic MakMuftic commented May 20, 2024 •
edited
Loading

Details

  • Refactored pipeline so it supports both old shared configuration format/files and new v3 format of shared configuration.
  • Added v3 JSON schema and CI validation
  • Made changes required for v3 SDK 👇

Changes to the devnet shared configuration

  • renamed domain property id to sygmaId
  • renamed resource property resourceId to sygmaResourceId
  • added domain property caipId - representing caip2 compatible domain identifier
  • added resource property caip19 - representing caip19 compatible resource identifier

@MakMuftic MakMuftic marked this pull request as ready for review May 21, 2024 09:44
@MakMuftic MakMuftic changed the title devnet: shared configuration upgrades feat: shared configuration upgrades May 21, 2024
@tcar121293
update contract addresses;
bb72d7e 
Signed-off-by: tcar <tcar121293@gmail.com>
@tcar121293 tcar121293 merged commit e07ced2 into main May 24, 2024
5 checks passed
@tcar121293 tcar121293 mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcar121293 tcar121293 tcar121293 approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@Lykhoyda Lykhoyda Awaiting requested review from Lykhoyda

@wainola wainola Awaiting requested review from wainola

@saadahmsiddiqui saadahmsiddiqui Awaiting requested review from saadahmsiddiqui

Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MakMuftic @tcar121293 @mpetrun5