Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix broken behat test #419

Merged
merged 1 commit into from
Sep 30, 2024
Merged

MNT Fix broken behat test #419

merged 1 commit into from
Sep 30, 2024

Conversation

GuySartorelli
Copy link
Collaborator

Fixes https://github.com/symbiote/silverstripe-gridfieldextensions/actions/runs/11095801859/job/30824884211

And I should see "John" in the ".nested-gridfield.odd .ss-gridfield-item.last.even" element # SilverStripe\Framework\Tests\Behaviour\FeatureContext::assertElementContainsText()
The text "John" was not found in the text of the element matching css ".nested-gridfield.odd .ss-gridfield-item.last.even". (Behat\Mink\Exception\ElementTextException)

This got broken as a result of silverstripe/silverstripe-framework#11395

Issue

@GuySartorelli GuySartorelli mentioned this pull request Sep 30, 2024
Open
@emteknetnz emteknetnz merged commit 3025a1f into symbiote:4.1 Sep 30, 2024
10 checks passed
@emteknetnz emteknetnz deleted the pulls/4.1/fix-behat branch September 30, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz