diff comparison from last pull request #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Low m0 inaccurate and needs debugging - Inf m0 within 1% but incorrect (should be closer)
…sed panels while also being able to account for heaving/not heaving
Update infinite_limits with current testing abilities.
- Some code cleanup for merging
Finished Infinite Frequency Limit: - Fixes bug with infinite frequency implementation - Adds scaled bessel functions to increase range of inputs that don't break outputs
…updates test configuration data accordingly.
- New multi_condensed.py file is used instead of copying the contents of multi_MEEM to math needing to run MEEM - Convergence and slant studies reorganized for clarity, can directly be run forsome results.
…ailures Addresses the recent test failures in `test_multi_equations.py`. Specifically: - Corrected the `Z_k_e` and `diff_Z_k_e` function implementations to align with the expected mathematical formulas. Debugging revealed discrepancies in the calculation logic. - Ensured the `excitation_phase` function correctly calls the `scale` utility by passing the `a` array. - Updated the `test_excitation_phase` signature to properly inject the `a` fixture. - Confirmed all related tests now pass, indicating accurate function behavior.
added two scripts to profile in Spyder
To guide users on the end-to-end usage, a comprehensive and runnable example script was needed. updates `meem_engine_example.py`, a self-contained script that demonstrates the primary workflow for setting up, solving, and visualizing a problem. The example script covers: - Defining the physical parameters for a multi-cylinder system. - Creating the necessary `Geometry` and `MEEMProblem` objects. - Initializing the `MEEMEngine`. - Running a frequency sweep with `run_and_store_results`. - Solving for a single frequency to calculate detailed potential and velocity fields. - Visualizing the results
To clarify the setup process for a simulation, updates example script, `meem_problem_example.py`. This script serves as a tutorial for the `MEEMProblem` class, demonstrating the standard user workflow: - First, creating a `Geometry` object to define the physical system. - Then, instantiating a `MEEMProblem` with that geometry. - Finally, using the `set_frequencies_modes` method to define the specific computations to be run. This example helps illustrate the role of `MEEMProblem` that is passed to the `MEEMEngine`.
- loop over problem.modes
- updated building params method to include optional slant
- from requirements.txt as it caused pip install errors due to invalid syntax. - Python version constraints are already correctly specified in pyproject.toml
Main code review fixes
updating diagrams
update prep for pypi and conda
update conda version of package
making methods in problem_cache private
update package requirements
The `build_domain_params` method now automatically assigns top and bottom boundary conditions based on the domain's category, ensuring consistency and aligning the setup with the physical model's specifications.
This change removes the need for manual BC configuration when creating domain parameters. The logic is as follows:
- **Exterior domains**: Top BC is set to 'Wave surface'.
- **Interior domains** ('inner', 'outer'): Top BC is set to 'Body'.
- **All domains**: Bottom BC is set to 'Sea floor'.
The test suites and example scripts have been updated to reflect this new deterministic behavior.
Automatically set domain boundary conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.