Merge pull request #273 from symfony-cmf/cleanup-typing

restricted some interfaces too much
symfony-cmf · Feb 7, 2022 · d1fc412 · d1fc412
2 parents 791b332 + 9724a91
commit d1fc412
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/RedirectRouteInterface.php b/src/RedirectRouteInterface.php
@@ -45,9 +45,9 @@ interface RedirectRouteInterface extends RouteObjectInterface
      *
      * If this is non-empty, the other methods won't be used.
      *
-     * @return string target absolute uri
+     * @return string|null target absolute uri
      */
-    public function getUri(): string;
+    public function getUri(): ?string;
 
     /**
      * Get the target route document this route redirects to.
@@ -62,7 +62,7 @@ public function getRouteTarget(): ?SymfonyRoute;
      * Get the name of the target route for working with the symfony standard
      * router.
      */
-    public function getRouteName(): string;
+    public function getRouteName(): ?string;
 
     /**
      * Whether this should be a permanent or temporary redirect.

diff --git a/src/RouteProviderInterface.php b/src/RouteProviderInterface.php
@@ -79,5 +79,5 @@ public function getRouteByName(string $name): SymfonyRoute;
      *
      * @return SymfonyRoute[] Iterable list with the keys being the names from the $names array
      */
-    public function getRoutesByNames(?array $names): array;
+    public function getRoutesByNames(?array $names = null): iterable;
 }
diff --git a/tests/Unit/Routing/DynamicRouterTest.php b/tests/Unit/Routing/DynamicRouterTest.php
@@ -32,7 +32,6 @@
 
 class DynamicRouterTest extends TestCase
 {
-
     /**
      * @var UrlMatcherInterface&MockObject
      */