Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid making the sync workflow fail when there is no change #52

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

stof
Copy link
Member

@stof stof commented Feb 7, 2024

This makes the maintenance easier as a failed workflow will actually mean that something is broken in it.
Not having to synchronize any change is something that will happen very often.

This makes the maintenance easier as a failed workflow will actually mean that something is broken in it.
Not having to synchronize any change is something that will happen very often.
@stof
Copy link
Member Author

stof commented Feb 7, 2024

@Nyholm should this workflow really run 3 times a day ? This might not let us enough time to react to the created PR to merge it before the next run.

@Nyholm
Copy link
Member

Nyholm commented Feb 7, 2024

This makes the maintenance easier as a failed workflow will actually mean that something is broken in it.

Lovely. Thank you.

should this workflow really run 3 times a day ?

We will never have two open PRs. The second run will just update the exiting PR.

I've actually run this workflow multiple times already.

Screenshot 2024-02-07 at 13 19 52

@Nyholm Nyholm merged commit 05136f9 into master Feb 7, 2024
3 checks passed
@Nyholm Nyholm deleted the stof-patch-1 branch February 7, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants