Allow to use env var for log levels of console logger #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
log-level-console
branch
from
320d493 to
d7a31bd
Compare
GromNaN
commented
Dec 20, 2022
| $level = Logger::toMonologLevel(is_numeric($level) ? (int) $level : $level); | ||
| } | ||
| } catch (\Psr\Log\InvalidArgumentException $e) { | ||
| throw new InvalidConfigurationException(sprintf( |
There was a problem hiding this comment.
To keep this validation, we could evaluate the value at build time, but pass the configured value (with env placeholder).
GromNaN
force-pushed
the
log-level-console
branch
from
d7a31bd to
983675a
Compare
lyrixx
approved these changes
Feb 9, 2023
|
Closing as this this removes the validation during the build time. The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #446
The console logger have a map of verbosity => log level that should be configurable with env vars.
Disadvantage: in case of invalid log level, the exception cannot be contextualized with the output verbosity.
The tests in this PR will conflict with #439