Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recipe for datana-gmbh/datapool-api #1558

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

OskarStark
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) October 31, 2023 10:43
@github-actions
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1558/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1558/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'datana-gmbh/datapool-api:^3.16'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

datana-gmbh/datapool-api

1.0 vs 2.3
diff --git a/datana-gmbh/datapool-api/1.0/config/packages/datana_datapool_api.yaml b/datana-gmbh/datapool-api/2.3/config/packages/datana_datapool_api.yaml
index 4ac8c60e..b0d5635d 100644
--- a/datana-gmbh/datapool-api/1.0/config/packages/datana_datapool_api.yaml
+++ b/datana-gmbh/datapool-api/2.3/config/packages/datana_datapool_api.yaml
@@ -20,20 +20,26 @@ services:
     Datana\Datapool\Api\ChatProtocolApi: null
     Datana\Datapool\Api\NullChatProtocolApi: null
 
+    Datana\Datapool\Api\SystemEventLogApi: null
+    Datana\Datapool\Api\NullSystemEventLogApi: null
+
 when@prod:
     services:
         Datana\Datapool\Api\AktenEventLogApiInterface: '@Datana\Datapool\Api\AktenEventLogApi'
         Datana\Datapool\Api\AktenzeichenApiInterface: '@Datana\Datapool\Api\AktenzeichenApi'
         Datana\Datapool\Api\ChatProtocolApiInterface: '@Datana\Datapool\Api\ChatProtocolApi'
+        Datana\Datapool\Api\SystemEventLogApiInterface: '@Datana\Datapool\Api\SystemEventLogApi'
 
 when@dev:
     services:
         Datana\Datapool\Api\AktenEventLogApiInterface: '@Datana\Datapool\Api\NullAktenEventLogApi'
         Datana\Datapool\Api\AktenzeichenApiInterface: '@Datana\Datapool\Api\FakeAktenzeichenApi'
         Datana\Datapool\Api\ChatProtocolApiInterface: '@Datana\Datapool\Api\NullChatProtocolApi'
+        Datana\Datapool\Api\SystemEventLogApiInterface: '@Datana\Datapool\Api\NullSystemEventLogApi'
 
 when@test:
     services:
         Datana\Datapool\Api\AktenEventLogApiInterface: '@Datana\Datapool\Api\NullAktenEventLogApi'
         Datana\Datapool\Api\AktenzeichenApiInterface: '@Datana\Datapool\Api\FakeAktenzeichenApi'
         Datana\Datapool\Api\ChatProtocolApiInterface: '@Datana\Datapool\Api\NullChatProtocolApi'
+        Datana\Datapool\Api\SystemEventLogApiInterface: '@Datana\Datapool\Api\NullSystemEventLogApi'
2.3 vs 3.16
diff --git a/datana-gmbh/datapool-api/2.3/config/packages/datana_datapool_api.yaml b/datana-gmbh/datapool-api/3.16/config/packages/datana_datapool_api.yaml
index b0d5635d..e2e634ae 100644
--- a/datana-gmbh/datapool-api/2.3/config/packages/datana_datapool_api.yaml
+++ b/datana-gmbh/datapool-api/3.16/config/packages/datana_datapool_api.yaml
@@ -23,6 +23,9 @@ services:
     Datana\Datapool\Api\SystemEventLogApi: null
     Datana\Datapool\Api\NullSystemEventLogApi: null
 
+    Datana\Datapool\Api\KnowledgeToolsApi: null
+    Datana\Datapool\Api\KnowledgeToolsApiInterface: '@Datana\Datapool\Api\KnowledgeToolsApi'
+
 when@prod:
     services:
         Datana\Datapool\Api\AktenEventLogApiInterface: '@Datana\Datapool\Api\AktenEventLogApi'

@OskarStark OskarStark requested review from fabpot and Nyholm November 3, 2023 10:26
@OskarStark
Copy link
Contributor Author

@Nyholm @fabpot friendly ping

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.
Thank you

@symfony-recipes-bot symfony-recipes-bot merged commit 4def1d1 into symfony:main Nov 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants