Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for jeandanyel/crud-bundle #1707

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

jeandanyel
Copy link
Contributor

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 15, 2024 16:45
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1707/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1707/index.json
  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
    composer req 'jeandanyel/crud-bundle:^0.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@diimpp diimpp changed the title Add recipe for jeandanyel/list-bundle Add recipe for jeandanyel/crud-bundle Nov 16, 2024
@symfony-recipes-bot symfony-recipes-bot merged commit 1056c91 into symfony:main Nov 16, 2024
1 of 2 checks passed
@diimpp
Copy link
Member

diimpp commented Nov 16, 2024

@jeandanyel Hi, please take notice, that requirement

https://packagist.org/packages/jeandanyel/list-bundle

https://packagist.org/packages/symfony/options-resolver: ^7.1

for list-bundle is incorrect (since 7.1 requires 8.2 at minimum, while project is at 8.0 at minimum) and it should be ^6.4 || ^7.0.

@jeandanyel
Copy link
Contributor Author

Hi @diimpp, thank you for pointing that out. I’ve made the correction 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants