Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gotenberg bundle default DSN #1715

Closed
wants to merge 1 commit into from
Closed

Conversation

norkunas
Copy link

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 28, 2024 10:29
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1715/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1715/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'sensiolabs/gotenberg-bundle:^0.1'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @norkunas, GotenbergBundle maintainers seems to be okay with localhost as default.

https://github.com/sensiolabs/GotenbergBundle?tab=readme-ov-file#with-symfony-flex

image

You only need gotenberg host if you're calling your php script from the same docker setup, from host point of view it will be localhost.

Could you please start with GotenbergBundle readme and after it will be accepted we can merge it here?

@norkunas
Copy link
Author

norkunas commented Dec 5, 2024

Ok, I didn't read the readme :D one of our devs installed gotenberg bundle and complained that it didn't work. if the docker image is added by flex then it'd be expected to get the http://gotenberg url instead of localhost. As it's explained in the readme (where I should have pointed our dev) thefore I can close this

@diimpp diimpp closed this Dec 5, 2024
auto-merge was automatically disabled December 5, 2024 13:13

Pull request was closed

@norkunas norkunas deleted the patch-1 branch December 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants