Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inspector.dev ignored routes and commands #1726

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

ilvalerione
Copy link
Contributor

@ilvalerione ilvalerione commented Dec 10, 2024

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) December 10, 2024 09:59
Copy link

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1726/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1726/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'inspector-apm/inspector-symfony:^1.3'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

inspector-apm/inspector-symfony

1.0 vs 1.3
diff --git a/inspector-apm/inspector-symfony/1.0/config/packages/inspector.yaml b/inspector-apm/inspector-symfony/1.3/config/packages/inspector.yaml
index 4c8f9405..bc754f73 100644
--- a/inspector-apm/inspector-symfony/1.0/config/packages/inspector.yaml
+++ b/inspector-apm/inspector-symfony/1.3/config/packages/inspector.yaml
@@ -1,18 +1,18 @@
 inspector:
     ingestion_key: '%env(INSPECTOR_INGESTION_KEY)%'
+    enabled: true
+    transport: async
     ignore_routes:
-        - '_wdt'
-        - '_profiler'
-        - '_profiler_home'
-        - '_profiler_search'
-        - '_profiler_search_bar'
-        - '_profiler_phpinfo'
-        - '_profiler_search_results'
-        - '_profiler_open_file'
-        - '_profiler_router'
-        - '_profiler_exception'
-        - '_profiler_exception_css'
+        - '/_wdt*'
+        - '/_profiler*'
     ignore_commands:
+        - 'messenger:consume'
+        - 'assets:install'
+        - 'cache:clear'
+        - 'doctrine:migrations:migrate'
+        - 'schedule:run'
+
+        # Development commands section
         - 'debug:autowiring'
         - 'debug:config'
         - 'debug:container'

@symfony-recipes-bot symfony-recipes-bot merged commit 639bced into symfony:main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants