Merge pull request #1330 from stof/add_internal_types

Add some types in the internal implementation of Encore
symfony · Sep 6, 2024 · 1d49c5d · 1d49c5d
2 parents 1a5e2f8 + 12c8144
commit 1d49c5d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/config-generator.js b/lib/config-generator.js
@@ -82,6 +82,9 @@ class ConfigGenerator {
             this.webpackConfig.runtimeConfig.devServerFinalIsHttps = false;
         }
 
+        /**
+         * @type {import('webpack').Configuration}
+         */
         const config = {
             context: this.webpackConfig.getContext(),
             entry: this.buildEntryConfig(),
@@ -158,6 +161,9 @@ class ConfigGenerator {
     }
 
     buildEntryConfig() {
+        /**
+         * @type {Record<string, string[]>}
+         */
         const entry = {};
 
         for (const [entryName, entryChunks] of this.webpackConfig.entries) {
@@ -544,7 +550,7 @@ class ConfigGenerator {
         }
 
         if (this.webpackConfig.shouldUseSingleRuntimeChunk) {
-            optimization.runtimeChunk = 'single';
+            optimization.runtimeChunk = /** @type {const} */ ('single');
         }
 
         optimization.splitChunks = applyOptionsCallback(
@@ -558,7 +564,7 @@ class ConfigGenerator {
     buildCacheConfig() {
         const cache = {};
 
-        cache.type = 'filesystem';
+        cache.type = /** @type {const} */ ('filesystem');
         cache.buildDependencies = this.webpackConfig.persistentCacheBuildDependencies;
 
         applyOptionsCallback(

diff --git a/lib/loaders/css.js b/lib/loaders/css.js
@@ -25,6 +25,9 @@ module.exports = {
     getLoaders(webpackConfig, useCssModules = false) {
         const usePostCssLoader = webpackConfig.usePostCssLoader;
 
+        /**
+         * @type {boolean|object}
+         */
         let modulesConfig = false;
         if (useCssModules) {
             modulesConfig = {