Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support of webpack-dev-server ^4.8, add support for webpack-dev-server ^5.0 #1318

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Aug 31, 2024

Close #1290

Upgrade webpack-dev-server didn't have impact for Encore itself, but it can be the case for end-users.

After upgrading webpack-dev-server to ^5.0, my project that use the following devServer configuration is still working as expected:

Encore.configureDevServerOptions((options) => {
    options.allowedHosts = 'all';
    options.client = {
        overlay: false, // hidden overlay: multiple errors caused by third-party scripts
    };
    options.server = {
        type: 'https',
        options: {
            pfx: path.join(process.env.HOME, '.symfony5/certs/default.p12'),
        },
    };
})

@Kocal Kocal force-pushed the feat/webpack-encore-1290 branch 2 times, most recently from fc3f6a3 to 77c6c42 Compare August 31, 2024 20:54
@Kocal Kocal requested a review from stof August 31, 2024 20:54
@@ -12,6 +12,8 @@ This is a new major version that contains several backwards-compatibility breaks

* #1309 Drop ESLint integration (@Kocal)

* #1318 Drop webpack-dev-server 4 support, only webpack-dev-server 5 is supported (@Kocal)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest mentioning that the supported option in the configuration callback have changed, with a link to their changelog. They have BC breaks in their configuration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Kocal Kocal merged commit 005a976 into symfony:main Sep 2, 2024
28 checks passed
@Kocal Kocal deleted the feat/webpack-encore-1290 branch September 2, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to webpack-dev-server 5
2 participants