Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop css-minimizer-webpack-plugin 5 support, only css-minimizer-webpack-plugin 7 is supported #1320

Closed
wants to merge 1 commit into from
Closed

Drop css-minimizer-webpack-plugin 5 support, only css-minimizer-webpack-plugin 7 is supported #1320

wants to merge 1 commit into from

Commits on Sep 2, 2024

  1. feature symfony#1321 Drop support for Node.js 19 and 21 (Kocal) 

    This PR was merged into the main branch.

Discussion
----------

Drop support for Node.js 19 and 21

Due to the `>=18.0.0` version constraint in `engines.node`, it means that we allows Node.js 19 and 21, but, we don't want that.

Odds versions are supported only 6 months, it only helps library maintainers to update their library comptability with a new Node.js LTS-version. You can see on https://nodejs.org/fr/about/previous-releases that Node.js 19 is not present and Node.js 21 support has been stopped around ~may 2024.

Some of our dependencies explicitly does not support explicitly Node.js 19/21, like css-minimizer-webpack-plugin that [I've tried to upgrade to v5](https://github.com/symfony/webpack-encore/actions/runs/10654621974/job/29531168804?pr=1320):
```
yarn install v1.22.22
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
error cssnano@7.0.5: The engine "node" is incompatible with this module. Expected version "^18.12.0 || ^20.9.0 || >=22.0". Got "21.7.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
```

Since we plan to release a new major version of Encore, it's the good moment.

WDYT?

Commits
-------

40ce3c9 Drop support for Node.js 19 and 21
    @Kocal
    Kocal committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9658190 View commit details
    Browse the repository at this point in the history