Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node.js 19 and 21 #1321

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Drop support for Node.js 19 and 21 #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/high-depends.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['18', '20', '21', '22']
node-versions: ['18', '20', '22']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we run tests on node 23 ?

Copy link
Member Author

@Kocal Kocal Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it looks like it will be available in ~october 2024, and I don't find anything in setup-node to use a dev version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge, I've opened #1323 so we won't forget


steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/low-depends.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['18', '20', '21', '22']
node-versions: ['18', '20', '22']

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stable-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-2019]
node-versions: ['18', '20', '21', '22']
node-versions: ['18', '20', '22']

steps:
- name: Checkout
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ This is a new major version that contains several backwards-compatibility breaks

### BC Breaks

* #1321 Drop support of Node.js 19 and 21 (@Kocal)

* #1307 Drop `webpack-cli` 4 support, only `webpack-cli` ^5.1.4 is supported (@Kocal)

* #1308 Drop Vue 2 support (End-Of-Life), only Vue 3 is supported (@Kocal)
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"url": "https://github.com/symfony/webpack-encore/issues"
},
"engines": {
"node": ">=18.0.0"
"node": "^18.0.0 || ^20.0.0 || >=22.0"
},
"homepage": "https://github.com/symfony/webpack-encore",
"dependencies": {
Expand Down