Upgrade assets-webpack-plugin to ^7.1, leverage integrity calculations to assets-webpack-plugin and webpack-subresource-integrity #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to assets-webpack-plugin and webpack-subresource-integrity
stof
reviewed
Sep 16, 2024
| @@ -558,6 +585,10 @@ class ConfigGenerator { | |||
| splitChunks | |||
| ); | |||
|
|
|||
| if (this.webpackConfig.useIntegrity > 0) { | |||
There was a problem hiding this comment.
Bad search/replace, before introducing webpackConfig.useIntegrity, I've used webpackConfig.integrityAlgorithms.length > 0 to check if integrity was enabled.
| @@ -216,6 +217,9 @@ | |||
| }, | |||
| "webpack-notifier": { | |||
| "optional": true | |||
| }, | |||
| "webpack-subresource-integrity": { | |||
| "optional": true | |||
There was a problem hiding this comment.
listing it here without putting it in peerDependencies does not make sense.
|
Closing in favor of a new PR, which will drop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #969, but the PR is not ready yet:
assets-webpack-pluginadd integrity hashes to theentrypoints.jsonis different that our actual format, it's a breaking change (that will impact Encore and WebpackEncoreBundle users), but maybe it can be avoided withprocessOutput