Skip to content

Commit

Permalink
Delete pylint
Browse files Browse the repository at this point in the history
Move everything to ruff

Topic: rm-pylint
Relative: sf-uv
  • Loading branch information
aaron-skydio committed Dec 18, 2024
1 parent 5392e25 commit bad4f15
Show file tree
Hide file tree
Showing 152 changed files with 590 additions and 1,246 deletions.
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,21 @@ check_types:
--exclude "symforce/examples/.*/gen/python2\.7/lcmtypes" \
--exclude third_party

# Run pylint on the symforce package, and tests
# Run ruff check on the symforce package, and tests
# TODO(aaron): Also run on other python code in symforce. Generated code will require a different
# config since it is py6 and contains a lot of duplicate code
pylint:
$(PYTHON) -m pylint symforce test/*.py
ruff_check:
ruff check

# Lint check for formatting and type hints
# This needs pass before any merge.
lint: check_types check_format pylint
lint: check_types check_format ruff_check

# Clean all artifacts
clean: docs_clean coverage_clean
rm -rf $(BUILD_DIR)

.PHONY: all reqs format check_format check_types pylint lint clean
.PHONY: all reqs format check_format check_types ruff_check lint clean

# -----------------------------------------------------------------------------
# Tests
Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
# -- Project information -----------------------------------------------------

project = "symforce"
copyright = "2022, Skydio, Inc"
copyright = "2022, Skydio, Inc" # noqa: A001
author = "Skydio"

# The short X.Y version
Expand Down
4 changes: 2 additions & 2 deletions gen/python/sym/atan_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/python/sym/double_sphere_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/python/sym/equirectangular_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions gen/python/sym/linear_camera_cal.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/atan_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/atan_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/atan_camera_cal/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/double_sphere_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/double_sphere_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/double_sphere_camera_cal/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/equirectangular_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/equirectangular_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/linear_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/linear_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/linear_camera_cal/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/polynomial_camera_cal/camera_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/polynomial_camera_cal/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/polynomial_camera_cal/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/pose2/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/pose2/lie_group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion gen/python/sym/ops/pose3/group_ops.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit bad4f15

Please sign in to comment.