[ops/ts] - fixed eslint issues

client/ts/src/errors.spec.ts

@@ -1,4 +1,3 @@
-import { BaseTypedError, TypedError } from "@synnaxlabs/freighter";
 import { MatchableErrorType } from "@synnaxlabs/freighter/src/errors";
 import { describe, expect, test } from "vitest";
 

client/ts/src/ontology/group/writer.ts

@@ -10,7 +10,7 @@
 import { type UnaryClient } from "@synnaxlabs/freighter";
 import { z } from "zod";
 
-import { type Payload, groupZ } from "@/ontology/group/payload";
+import { groupZ,type Payload } from "@/ontology/group/payload";
 import { type ID, idZ } from "@/ontology/payload";
 
 const resZ = z.object({

console/src/docs/slice.ts

@@ -9,7 +9,6 @@
 
 import { createSlice, type PayloadAction } from "@reduxjs/toolkit";
 import { migrate } from "@synnaxlabs/x";
-import { z } from "zod";
 
 /**
  * The name of the docs slice in a larger store.

console/src/fs/LoadFileContents.tsx

@@ -8,7 +8,7 @@
 // included in the file licenses/APL.txt.
 
 import { Icon } from "@synnaxlabs/media";
-import { Align, Button, Input, state } from "@synnaxlabs/pluto";
+import { Align, Button, Input } from "@synnaxlabs/pluto";
 import { binary } from "@synnaxlabs/x";
 import { open } from "@tauri-apps/plugin-dialog";
 import { readFile } from "@tauri-apps/plugin-fs";

console/src/hardware/ni/device/types.ts

@@ -7,7 +7,6 @@
 // License, use of this software will be governed by the Apache License, Version 2.0,
 // included in the file licenses/APL.txt.
 
-import { task } from "@synnaxlabs/client";
 import { z } from "zod";
 
 // VENDOR

console/src/hardware/ni/task/AnalogRead.tsx

@@ -9,7 +9,7 @@
 
 import { NotFoundError, QueryError } from "@synnaxlabs/client";
 import { Icon } from "@synnaxlabs/media";
-import { Button, Form, Header, Menu, Status, Synnax } from "@synnaxlabs/pluto";
+import { Form, Header, Menu, Status, Synnax } from "@synnaxlabs/pluto";
 import { Align } from "@synnaxlabs/pluto/align";
 import { Input } from "@synnaxlabs/pluto/input";
 import { List } from "@synnaxlabs/pluto/list";

console/src/hardware/ni/task/DigitalRead.tsx

@@ -7,7 +7,7 @@
 // License, use of this software will be governed by the Apache License, Version 2.0,
 // included in the file licenses/APL.txt.
 
-import { NotFoundError, QueryError } from "@synnaxlabs/client";
+import { NotFoundError } from "@synnaxlabs/client";
 import { Icon } from "@synnaxlabs/media";
 import {
   Align,

console/src/hardware/ni/task/types.ts

@@ -67,10 +67,6 @@ export type UnitsInOz = z.infer<typeof unitsInOzZ>;
 export const unitsFtLbsZ = z.literal("FootPounds");
 export type UnitsFtLbs = z.infer<typeof unitsFtLbsZ>;
 
-const resistanceZ = z.number().refine((val) => val > 0, {
-  message: "Value must be greater than 0",
-});
-
 export const unitsZ = z.union([
   unitsVoltsZ,
   unitsAmpsZ,

console/src/hooks/useLoadRemote.ts

@@ -1,7 +1,7 @@
 import { PayloadAction } from "@reduxjs/toolkit";
 import { Synnax } from "@synnaxlabs/client";
 import { Status, Synnax as PSynnax, useAsyncEffect } from "@synnaxlabs/pluto";
-import { compare, migrate } from "@synnaxlabs/x";
+import { migrate } from "@synnaxlabs/x";
 import { useMutation } from "@tanstack/react-query";
 import { nanoid } from "nanoid";
 import { useDispatch } from "react-redux";

console/src/layout/Window.tsx

@@ -26,8 +26,8 @@ import { Controls } from "@/components";
 import { Menu } from "@/components/menu";
 import { CSS } from "@/css";
 import { Content } from "@/layout/Content";
-import { WindowProps } from "@/layout/slice";
 import { useSelect } from "@/layout/selectors";
+import { WindowProps } from "@/layout/slice";
 
 export interface NavTopProps extends Pick<WindowProps, "showTitle" | "navTop"> {
   title: string;

console/src/layout/external.ts

@@ -10,11 +10,11 @@
 export * from "@/layout/Content";
 export * from "@/layout/context";
 export * from "@/layout/hooks";
-export * from "@/layout/slice";
 export * from "@/layout/middleware";
 export * from "@/layout/Modals";
 export * from "@/layout/palette";
 export * from "@/layout/Selector";
 export * from "@/layout/selectors";
 export * from "@/layout/slice";
+export * from "@/layout/slice";
 export * from "@/layout/Window";

console/src/layouts/Mosaic.tsx

@@ -39,7 +39,6 @@ import { createSelector } from "@/layouts/Selector";
 import { LinePlot } from "@/lineplot";
 import { SERVICES } from "@/services";
 import { type RootStore } from "@/store";
-import { Vis } from "@/vis";
 
 const EmptyContent = (): ReactElement => (
   <Eraser.Eraser>

console/src/lineplot/migrations/v0.ts

@@ -8,7 +8,7 @@
 // included in the file licenses/APL.txt.
 
 import { Text, Viewport } from "@synnaxlabs/pluto";
-import { bounds, box, dimensions, direction, migrate, xy } from "@synnaxlabs/x";
+import { bounds, box, dimensions, direction, xy } from "@synnaxlabs/x";
 import { z } from "zod";
 
 import {

console/src/ontology/Tree.tsx

@@ -546,6 +546,7 @@ export const Tree = (): ReactElement => {
         onDrop={handleDrop}
         onDoubleClick={handleDoubleClick}
         showRules
+        loading={loading}
         {...treeProps}
       >
         {item}

console/src/store.ts

@@ -11,7 +11,7 @@ import type { Reducer, Store } from "@reduxjs/toolkit";
 import { combineReducers, Tuple } from "@reduxjs/toolkit";
 import { Drift } from "@synnaxlabs/drift";
 import { TauriRuntime } from "@synnaxlabs/drift/tauri";
-import { type deep, migrate } from "@synnaxlabs/x";
+import { type deep } from "@synnaxlabs/x";
 
 import { Cluster } from "@/cluster";
 import { Docs } from "@/docs";

console/src/vis/Toolbar.tsx

@@ -14,6 +14,7 @@ import { type FC, type ReactElement } from "react";
 import { ToolbarHeader, ToolbarTitle } from "@/components";
 import { Layout } from "@/layout";
 import { Layouts } from "@/layouts";
+import { Selector } from "@/layouts/Selector";
 import { LinePlot } from "@/lineplot";
 import { Schematic } from "@/schematic";
 import { type LayoutType } from "@/vis/types";
@@ -26,19 +27,10 @@ interface ToolbarProps {
   layoutKey: string;
 }
 
-const SelectVis = ({ layoutKey }: ToolbarProps): ReactElement => (
-  <Align.Space justify="spaceBetween" style={{ height: "100%" }} empty>
-    <ToolbarHeader>
-      <VisToolbarTitle />
-    </ToolbarHeader>
-    {/* <LayoutSelector layoutKey={layoutKey} /> */}
-  </Align.Space>
-);
-
 const TOOLBARS: Record<LayoutType | "vis", FC<ToolbarProps>> = {
   schematic: Schematic.Toolbar,
   lineplot: LinePlot.Toolbar,
-  vis: SelectVis,
+  vis: ({ layoutKey }) => <Selector layoutKey={layoutKey} onClose={() => {}} />,
 };
 
 const NoVis = (): ReactElement => {

console/src/workspace/hooks.tsx

@@ -10,6 +10,8 @@ import { Layout } from "@/layout";
 import { type RootState } from "@/store";
 import { selectActiveKey, useSelectActiveKey } from "@/workspace/selectors";
 
+// this fixes conflicts between JSX and TS
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-constraint
 export const useSyncComponent = <P extends unknown>(
   name: string,
   layoutKey: string,

drift/src/external.ts

@@ -39,9 +39,9 @@ export {
   closeWindow,
   completeProcess,
   createWindow,
+  focusWindow,
   initialState,
   reducer,
-  focusWindow,
   registerProcess,
   reloadWindow,
   setWindowAlwaysOnTop,

pluto/src/button/Button.tsx

@@ -12,7 +12,7 @@ import "@/button/Button.css";
 import { Icon } from "@synnaxlabs/media";
 import { TimeSpan } from "@synnaxlabs/x/telem";
 import { toArray } from "@synnaxlabs/x/toArray";
-import { type ComponentPropsWithoutRef, type ReactElement } from "react";
+import { type ComponentPropsWithoutRef, type ReactElement, useCallback } from "react";
 
 import { type Align } from "@/align";
 import { Color } from "@/color";
@@ -100,8 +100,15 @@ export const Button = Tooltip.wrap(
 
     Triggers.use({
       triggers,
-      // @ts-expect-error
-      callback: ({ stage }) => stage === "end" && handleClick(new MouseEvent("click")),
+      callback: useCallback<(e: Triggers.UseEvent) => void>(
+        ({ stage }) => {
+          if (stage === "end")
+            handleClick(
+              new MouseEvent("click") as unknown as React.MouseEvent<HTMLButtonElement>,
+            );
+        },
+        [handleClick],
+      ),
     });
 
     return (

pluto/src/css/css.ts

@@ -13,7 +13,6 @@ import { type BEM, newBEM } from "@/css/bem";
 import { CSSGridBuilder } from "@/css/grid";
 import { applyCSSVars, removeCSSVars } from "@/css/vars";
 import { type ComponentSize } from "@/util/component";
-import { act } from '@testing-library/react';
 
 export interface CSSType extends BEM {
   visible: (visible: boolean) => string;

pluto/src/dialog/use.ts

@@ -11,8 +11,6 @@ import "@/dropdown/Dropdown.css";
 
 import { useCallback, useEffect, useState } from "react";
 
-import { Triggers } from "@/triggers";
-
 /** Props for the {@link use} hook. */
 export interface UseProps {
   initialVisible?: boolean;

pluto/src/state/state.ts

@@ -8,7 +8,7 @@
 // included in the file licenses/APL.txt.
 
 import { type Primitive, type UnknownRecord } from "@synnaxlabs/x";
-import { useId, useState } from "react";
+import { useState } from "react";
 
 export type State = Primitive | UnknownRecord;
 export type SetFunc<S, PS = S> = (prev: PS) => S;

pluto/src/tree/Tree.tsx

@@ -169,7 +169,7 @@ export interface TreeProps
   children?: RenderProp<ItemProps>;
   virtual?: boolean;
   showRules?: boolean;
-  loading?: string;
+  loading?: string | null | false;
 }
 
 export type Item = FC<ItemProps>;

pluto/src/triggers/Text.tsx

@@ -10,7 +10,6 @@
 import { Icon } from "@synnaxlabs/media";
 import { type ReactElement } from "react";
 
-import { Align } from "@/align";
 import { Text as Core } from "@/text";
 import { type Key, type Trigger } from "@/triggers/triggers";
 

pluto/src/triggers/hooks.tsx

@@ -30,9 +30,9 @@ export interface UseEvent {
 
 export interface UseProps {
   triggers?: Trigger[];
-  callback?: (e: UseEvent) => void;
   region?: RefObject<HTMLElement>;
   loose?: boolean;
+  callback?: (e: UseEvent) => void;
 }
 
 export const use = ({ triggers, callback: f, region, loose }: UseProps): void => {

x/ts/src/compare/compare.ts

@@ -125,8 +125,8 @@ export const stringsWithNumbers = (a: string, b: string): number => {
   const alphaNumericRegex = /([a-zA-Z]+)|(\d+)/g;
 
   // Remove separators and split into parts
-  const aParts = a.replace(/[\s_.\-]+/g, "").match(alphaNumericRegex);
-  const bParts = b.replace(/[\s_.\-]+/g, "").match(alphaNumericRegex);
+  const aParts = a.replace(/[\s_.-]+/g, "").match(alphaNumericRegex);
+  const bParts = b.replace(/[\s_.-]+/g, "").match(alphaNumericRegex);
 
   if (!aParts || !bParts) return 0;
 

x/ts/src/deep/path.ts

@@ -7,7 +7,6 @@
 // License, use of this software will be governed by the Apache License, Version 2.0,
 // included in the file licenses/APL.txt.
 
-import { caseconv } from "@/caseconv";
 import { type Join } from "@/join";
 import { type UnknownRecord } from "@/record";